Errores #85
"Hangup" buttom should terminate the "visual" call
| Status: | Comentarios | Start: | 07/21/2009 | |
|---|---|---|---|---|
| Priority: | Normal | Due date: | ||
| Assigned to: |  Saúl Ibarra Corretgé |
% Done: | 0% |
|
| Category: | YASS - core | |||
| Target version: | 1.0.0 |
Description
Imagine dialing to a non responding destination ("non responding" means no response at all, so there are INVITE retransmissions from YASS).
If then I press "Hangup" YASS doesn't send a CANCEL (and this is really correct: CANCEL can just be sent after receiving a 1XX reply). The problem is that the gui remains "blocked" until the INVITE expires.
The behaviour should be:
I press "Hangup" so the gui is "free" again to do a new call or receive calls. But in background YASS should remain with the previous dialog until it's correctly ended. This is:- If no 1XX is received then the INVITE expires => background dialog ended.
- If 1XX is received then send a CANCEL and act as usual => background dialog ended.
- If 200 is received for the background INVITE (it could occur) the YASS should send an ACK and inmediately a BYE => background dialog ended.
Yes, really a PITA, but it's the correct behaviour :)
History
Updated by Saúl Ibarra Corretgé over 2 years ago
- Status changed from Nueva to Comentarios
rev 132 should fix the issue. I tested it and it 'seemed' to work, but my testing environment it's not very good. Pease, test this carefully :)
Updated by Iñaki Baz Castillo over 2 years ago
Traceback (most recent call last):
File "/usr/bin/yassphone", line 22, in <module>
import yass.util.UnicodeQuickFix
ImportError: No module named UnicodeQuickFix
Please tell me which python deb package I must install for it. Also: shouldn't it be included in package dependencies?
Updated by Saúl Ibarra Corretgé over 2 years ago
Please, update to rev133. I added the files but forgot to make the packaging system install them :-/
Updated by Iñaki Baz Castillo over 2 years ago
It's improved but not fixed. Now what happens is:
- Call to sip:pepe@google.es (no response so retransmissions happen).
- Inmediatelly cancel the call and call to an answering number (i.e: sip:*501@oversip.net).
- The call is correctly established.
- When the first call to sip:pepe@google.es expires, the buttons are dissabled (Hangup, Xfer...).
A cancelled call should just exist in background and shouldn't notify visual elements to the GUI. For example, the log window should show "Cancelled" after pressing "Hangup" and show no more notifications for that call.
Updated by Saúl Ibarra Corretgé over 2 years ago
- Target version changed from 0.5.1 to 1.0.0
Fuck! That's not really possible right now, because of how events are handled. The GUI is just changed when the corresponding callback is called. It's not a function we call, instead the function is 'automagically' called and does it's stuff.
Having that said, I see it's a little anoying, but it's not doable right now, not without changing core and GUI communication mechanism for this specific behaviour.
Moreover, when we support multiple calls we'll have to handle this, so (even if I don't like to) I'm moving this to a further release :(
Updated by Iñaki Baz Castillo over 2 years ago
Yes, that's right: this issue would also appear when implementing various lines and being that an important but complex feature better to relax this bug until then :)